vregion: allocate the metadata separately#10811
Open
lyakh wants to merge 1 commit into
Open
Conversation
lyakh
requested review from
abonislawski,
dbaluta,
iuliana-prodan and
kv2019i
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a security/design issue in the Zephyr vregion allocator where the struct vregion metadata was previously stored inside the same virtual-memory buffer that can be mapped/writable by userspace modules; it now allocates the metadata separately to prevent userspace from modifying allocator internals.
Changes:
- Stop embedding
struct vregioninside the vpage-allocated region; allocate it separately viarmalloc(). - Adjust lifetime partition initialization to no longer skip over the embedded metadata.
- Ensure
vregion_put()frees both the vpage region and the separately allocated metadata.
Allocating vregion metadata together with the actual memory buffer makes that metadata accessible and writable by userspace modules. Fix this by allocating the metadata separately. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
approved these changes
May 27, 2026
Member
|
@lyakh can you check internal CI. Thanks |
Collaborator
|
Same test_05_hda_pass_through.py failing to XRUNs as in #10804 (on Intel MTL). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocating vregion metadata together with the actual memory buffer makes that metadata accessible and writable by userspace modules. Fix this by allocating the metadata separately.